Skip to content

vim/neovim: Backports fix for ACE #62713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2019
Merged

vim/neovim: Backports fix for ACE #62713

merged 2 commits into from
Jun 5, 2019
+45 −1

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Jun 5, 2019

Motivation for this change

Details:

The vim patch is the upstream commit, with incompatible changes removed.

The neovim patch is the upstream one directly.

Things done
  • ☑️ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • ☑️ NixOS
    • 🔲 macOS
    • 🔲 other Linux distributions
  • 🔲 Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • 🔲 Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • 🔲 Tested execution of all binary files (usually in ./result/bin/)
  • 🔲 Determined the impact on package closure size (by running nix path-info -S before and after)
  • ☑️ Assured whether relevant documentation is up to date
  • ☑️ Fits CONTRIBUTING.md.

@samueldr samueldr added 1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: port to stable A PR already has a backport to the stable release. labels Jun 5, 2019
@samueldr samueldr changed the title vim/nvim: Backports fix for ACE vim/neovim: Backports fix for ACE Jun 5, 2019
@ofborg ofborg bot added the 6.topic: vim label Jun 5, 2019
@ofborg ofborg bot requested review from lovek323 and garbas June 5, 2019 03:00
@andir andir merged commit 0d62805 into NixOS:release-19.03 Jun 5, 2019
@vcunat vcunat mentioned this pull request Jun 5, 2019
Closed
10 tasks
vcunat pushed a commit that referenced this pull request Jun 6, 2019
@andir @vcunat
Merge #62713: vim/neovim: Backports fix for ACE
9e5afbe 
(cherry picked from commit 0d62805)
The patch is fairly simple and the vulnerability seems important.
@samueldr samueldr deleted the stable/nvim-vim-ace branch November 4, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovek323 lovek323

@garbas garbas

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: vim 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samueldr @vcunat @andir