Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grafana-loki: init at 0.1.0 #62641

Merged
merged 1 commit into from Jun 4, 2019
Merged

grafana-loki: init at 0.1.0 #62641

merged 1 commit into from Jun 4, 2019

Conversation

WilliButz
Copy link
Member

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS (x86_64-linux & aarch64-linux)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
Copy link
Member

mmahut commented Jun 4, 2019

Thank you for this package. Do you mind adding this as a service as well maybe?

@WilliButz
Copy link
Member Author

@mmahut I have a module and test almost ready for upstreaming and will do that in the next days, but I wanted to get the package out of the way first, because this is as simple as a package gets :)

mmahut
mmahut approved these changes Jun 4, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looking forward for testing it. The binary itself is working fine.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries

@Ma27
Copy link
Member

Ma27 commented Jun 4, 2019

Built and tested locally 👍

@Ma27 Ma27 merged commit 6f60812 into NixOS:master Jun 4, 2019
@Ma27
Copy link
Member

Ma27 commented Jun 4, 2019

@WilliButz thanks!

@WilliButz WilliButz deleted the package-loki branch June 6, 2019 10:27
@WilliButz WilliButz mentioned this pull request Jun 27, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WilliButz @mmahut @Ma27