Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lutris: add hicolor theme #62674

Merged
merged 1 commit into from Jun 5, 2019
Merged

lutris: add hicolor theme #62674

merged 1 commit into from Jun 5, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Upon start of the application, you get greeted with:

(.lutris-0.5.2.1-wrapped:18904): Gtk-WARNING **: 11:21:17.422: Could not find the icon 'lutris'. The 'hicolor' theme
was not found either, perhaps you need to install it.
You can get a copy from:
        http://icon-theme.freedesktop.org/releases

This is to remove the warning and help with some of the icons.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

before:

$ nix path-info -S /nix/store/jrn1fjjaxfg6ksj28irgjjdmssn6xviz-lutris
/nix/store/jrn1fjjaxfg6ksj28irgjjdmssn6xviz-lutris       6312348432

after:

$ nix path-info -S ./result
/nix/store/n7ns10bscarg5nlsxvdfy9nwwm8nvdsb-lutris       6312477224

@worldofpeace
Copy link
Contributor

With the above change this should be good to merge 👍

@worldofpeace worldofpeace merged commit 0aeca5a into NixOS:master Jun 5, 2019
@worldofpeace
Copy link
Contributor

Thanks @jonringer

@jonringer jonringer deleted the lutris_add_hicolor branch June 5, 2019 01:36
@ghost
Copy link

ghost commented Jun 19, 2019

Unortunately this doesn't fix issue with embedded icons not showing https://github.com/lutris/lutris/tree/master/share/lutris/icons/hicolor/symbolic/apps

@jonringer
Copy link
Contributor Author

yea, I don't play games as much as I used to, otherwise i would be a lot more motivated to help build the lutris experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @worldofpeace