Implement forced-color-adjust CSS property #17188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 5, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1644498
branch
4 times, most recently
from
f5f0259
to
6fba5a6
Compare
This change adds support for the forced-color-adjust CSS property and updates the update_use_counter_css.py script to adjust enums.xml based on UseCounterHelper::MapCSSPropertyIdToCSSSampleIdForHistogram rather than the old location in UseCounter. Spec: https://www.w3.org/TR/css-color-adjust-1/#forced-color-adjust-prop Bug: 970285 Change-Id: I74759517a4d8be092b3b75301baca8a707c22ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644498 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#667852}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1644498
branch
from
6fba5a6
to
e1caad8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for the forced-color-adjust CSS property and
updates the update_use_counter_css.py script to adjust enums.xml based
on UseCounterHelper::MapCSSPropertyIdToCSSSampleIdForHistogram rather
than the old location in UseCounter.
Spec:
https://www.w3.org/TR/css-color-adjust-1/#forced-color-adjust-prop
Bug: 970285
Change-Id: I74759517a4d8be092b3b75301baca8a707c22ce7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644498
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#667852}