custom-elements: Add a test for upgrade failure due to non-null shado… #17162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w root and disabledFeatures Specification PR: whatwg/html#4673
wpt-pr-bot
requested review from
domenic,
hayatoito,
kojiishi,
rniwa,
snuggs and
TakayoshiKochi
3 tasks
EdgarChen
reviewed
Jun 5, 2019
annevk
approved these changes
Jun 7, 2019
That's a good idea. Done. |
annevk
approved these changes
Jun 11, 2019
annevk
added a commit
to whatwg/html
that referenced
this pull request
Jun 11, 2019
In particular if folks disable support for ShadowRoot and ElementInternals, this will make upgrade an element throw a NotSupportedError so element constructors only run with expected state. Tests: web-platform-tests/wpt#17162.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…w root and disabledFeatures
Specification PR: whatwg/html#4673