Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.azure-cli-core: init at 2.0.66 #62746

Closed
wants to merge 5 commits into from
Closed

pythonPackages.azure-cli-core: init at 2.0.66 #62746

wants to merge 5 commits into from
+226 −2

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Lay the groundwork for azure-cli repo, which is the "new azure cli standard". Also know as "azure cli 2.0".

The azure-cli package will have to wait for #60435 to be merged. And then nix will have modern support for azure :) (at least cli, nixops will be later)

Separate from #60435

Works with python2, python3.6 and python3.7. Unfortunately contextvars is needed for one of the dependencies (msrest) so it's broken on python3.5.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

$ nix path-info -Sh /nix/store/fsdvfxzz6bwgdvzdhnziw5rjnpjjr896-python3.6-azure-cli-core-2.0.66
/nix/store/fsdvfxzz6bwgdvzdhnziw5rjnpjjr896-python3.6-azure-cli-core-2.0.66 135.5M

Sorry, something went wrong.

@jonringer jonringer requested a review from FRidh as a code owner June 6, 2019 00:57
@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 labels Jun 6, 2019
@FRidh
Copy link
Member

FRidh commented Jun 15, 2019

Looks good to me. I've included it in #63169.

@FRidh FRidh closed this Jun 15, 2019
@jonringer jonringer deleted the add_azure_cli branch July 9, 2019 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh