fix global , and allow easy subclassing of Platform #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
==========================================
- Coverage 81% 80.97% -0.03%
==========================================
Files 31 31
Lines 4876 4879 +3
Branches 1050 1050
==========================================
+ Hits 3950 3951 +1
- Misses 799 801 +2
Partials 127 127
Continue to review full report at Codecov.
|
|
I fixed the typo in 45d1dc1. As for your other change, I don't think it's necessary. There is nothing wrong with using normal Python mechanisms like class MyOwnPlatform(TinyFPGAPlatform):
resources = TinyFPGAPlatform.resources + [
Resource(...)
] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global in the tinyfpga_bx board was an integer not a string. Added extend to platform to make subclassing and adding resources easier.