Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 74.0.3729.157 -> 75.0.3770.80 #62720

Merged
merged 2 commits into from Jun 5, 2019
Merged

chromium: 74.0.3729.157 -> 75.0.3770.80 #62720

merged 2 commits into from Jun 5, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Jun 5, 2019 •
edited

Motivation for this change

https://chromereleases.googleblog.com/2019/06/stable-channel-update-for-desktop.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested stable on x86_64: YouTube, WebGL, audio, Speedometer, Octane 2.0 are working

Tested dev on x86_64: YouTube, WebGL, audio are working

Not seeing any severe Linux bugs listed on https://crbug.com

ivan added 2 commits June 5, 2019 09:27
@ivan
chromium: use LLVM 8.0.0 to more closely match upstream
4481a01
@ivan
chromium: 74.0.3729.157 -> 75.0.3770.80
8c78ae2 
CVE-2019-5828 CVE-2019-5829 CVE-2019-5830 CVE-2019-5831
CVE-2019-5832 CVE-2019-5833 CVE-2019-5834 CVE-2019-5835
CVE-2019-5836 CVE-2019-5837 CVE-2019-5838 CVE-2019-5839
CVE-2019-5840

Update a patch for Python 3, fixes NixOS#62347.

Update a GN arg to fix this warning:

warning: The GN arg 'remove_webcore_debug_symbols' is deprecated and
warning: will be removed April 15, 2019. Please change your args.gn
warning: to use 'blink_symbol_level = 0'. https://crbug.com/943869
@ofborg ofborg bot requested a review from bendlas June 5, 2019 10:07
@ivan
Copy link
Member Author

ivan commented Jun 5, 2019

Updated with test results, please merge.

@andir
Copy link
Member

andir commented Jun 5, 2019

@ivan can you prepare the backport PR for this?

@andir andir merged commit 86d2752 into NixOS:master Jun 5, 2019
@ivan ivan mentioned this pull request Jun 5, 2019
Merged
10 tasks
@ivan
Copy link
Member Author

ivan commented Jun 5, 2019

@andir #62745 prepared but untested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendlas bendlas Awaiting requested review from bendlas

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivan @andir