Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aerc: init at 0.1.0 #62648

Closed
wants to merge 1 commit into from
Closed

aerc: init at 0.1.0 #62648

wants to merge 1 commit into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 4, 2019 •
edited

Motivation for this change

Fully tested and works, but since I will not switch to aerc in the near future, I just leave this as a draft until somebody wants to actually maintain this package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit June 4, 2019 06:34
kalbasit
kalbasit requested changes Jun 4, 2019
View reviewed changes
Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default all buildGoModule are assigned to me, feel free to remove the entire maintainers block.

pkgs/applications/networking/mailreaders/aerc/default.nix
# TODO: find a maintainer
];
license = licenses.mit;
platforms = platforms.unix;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

homepage?

kalbasit
kalbasit requested changes Jun 4, 2019
View reviewed changes
Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default all buildGoModule are assigned to me, feel free to remove the entire maintainers block.

@tadeokondrak
Copy link
Member

I'd be willing to maintain this package.

@Mic92
Copy link
Member Author

Mic92 commented Jun 7, 2019

@tadeokondrak feel free to open a pull request with my code.

@commando-crypto
Copy link

I've been using aerc built from this branch for 2 days now. Happy to open a PR with myself as maintainer.

@Mic92
Copy link
Member Author

Mic92 commented Jun 7, 2019

Multiple maintainers are also welcome.

@tadeokondrak tadeokondrak mentioned this pull request Jun 7, 2019
Merged
10 tasks
@Mic92 Mic92 deleted the aerc branch June 9, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @tadeokondrak @commando-crypto @kalbasit