lvm2: cleanup & fix eval error when systemd=null #62660
Merged
+5
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build lvm2 |
joachifm
commented
Jun 4, 2019
| sed -i /DEFAULT_SYS_DIR/d Makefile.in | ||
| sed -i /DEFAULT_PROFILE_DIR/d conf/Makefile.in | ||
| '' + stdenv.lib.optionalString (systemd != null) '' | ||
| substituteInPlace scripts/lvm2_activation_generator_systemd_red_hat.c \ | ||
| --replace /usr/bin/udevadm ${systemd}/bin/udevadm | ||
| ''; | ||
|
|
||
| # gcc: error: ../../device_mapper/libdevice-mapper.a: No such file or directory |
There was a problem hiding this comment.
Oops, forgot to remove this comment ...
The closure still picks up systemd via udev, however, overriding with eudev is necessary to avoid the reference.
--enable-applib has been removed.
joachifm
force-pushed
the
feat/lvm2-nonSystemd
branch
from
8b44cf5 to
ecd6931
Compare
|
@GrahamcOfBorg build systemd_with_lvm2 |
7c6f434c
approved these changes
Oct 14, 2019
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Oct 29, 2019
lvm2: cleanup & fix eval error when systemd=null (cherry picked from commit bd58bdc)
|
FTR I am getting the |
|
@joachifm How do you use this / for what? (I'm looking into building Edit: This works: https://github.com/nh2/parted/releases/tag/v3.3 nix-build -E '(import <nixpkgs> {}).pkgsStatic.parted.override { lvm2 = null; }' |
|
@nh2 I used it for a minimal Linux appliance that needed LVM2 but not systemd et al, so this was really part of a larger patch set that sought to allow stuff to be built without "unnecessary" (for my purposes) deps. A version that supports static linking sounds great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.