Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/undervolt: correct description of numerical input #62659

Closed
wants to merge 1 commit into from
Closed

nixos/undervolt: correct description of numerical input #62659

wants to merge 1 commit into from

Conversation

jarlg
Copy link
Contributor

@jarlg jarlg commented Jun 4, 2019

Motivation for this change

Undervolt only accepts negative integers, and crashes if given floating points.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

joachifm commented Jun 4, 2019

A further improvement is to enforce these constraints with types, e.g., types.int or whatever is appropriate in this case.

@Synthetica9
Copy link
Member

Synthetica9 commented Jun 4, 2019

Should the temperature targets also be negative integers?

Also, what does a value of "-2" represent? 2V? .2V (aka 2 decivolt)? 2 arbitrary steps on some scale? Would be nice to get that documented as well. (Same with temperature, probably in degrees Celsius, but would be nice to get that explicit as well)

@rycee
Copy link
Member

rycee commented Jun 4, 2019

Could change the type to types.strMatching "-[0-9]+" instead of types.str. Like @joachifm it seems that an integer type would be nicest but I guess string may have to do for backwards compatibility reasons?

@jarlg
Copy link
Contributor Author

jarlg commented Jun 6, 2019

Of course a proper integer type would be best, but it's a breaking change and I don't know how those are dealt with here.

@Synthetica9 Yes, they should be negative integer values. My config:

undervolt = {
  enable = true;
  coreOffset = "-80";
  gpuOffset = "-90";
}

corresponds to the command undervolt --core -80 --cache -80 --gpu -80. (The config links cache and core, but this isn't documented either.)

The values are in mV, which I agree should be documented as well. I suggest updating the text to say "[...] voltage (in mV) [...]".

@Synthetica9
Copy link
Member

@jarlg You don't use temp, tempBat, or tempAc in your config...? Am I missing something here? What do these values represent?

@jarlg
Copy link
Contributor Author

jarlg commented Jun 6, 2019

@Synthetica9 No, I am happy with my laptop's default (97C ). The CPU (or GPU) is throttled upon reaching these temperature thresholds.

@stale
Copy link

stale bot commented Jun 2, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@jarlg jarlg closed this Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants