New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/undervolt: correct description of numerical input #62659
Conversation
A further improvement is to enforce these constraints with types, e.g., |
Should the temperature targets also be negative integers? Also, what does a value of "-2" represent? 2V? .2V (aka 2 decivolt)? 2 arbitrary steps on some scale? Would be nice to get that documented as well. (Same with temperature, probably in degrees Celsius, but would be nice to get that explicit as well) |
Could change the type to |
Of course a proper integer type would be best, but it's a breaking change and I don't know how those are dealt with here. @Synthetica9 Yes, they should be negative integer values. My config:
corresponds to the command The values are in mV, which I agree should be documented as well. I suggest updating the text to say "[...] voltage (in mV) [...]". |
@jarlg You don't use |
@Synthetica9 No, I am happy with my laptop's default (97C ). The CPU (or GPU) is throttled upon reaching these temperature thresholds. |
Thank you for your contributions.
|
Motivation for this change
Undervolt only accepts negative integers, and crashes if given floating points.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)