Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.swagger-spec-validator: init at 2.4.3 #62661

Merged
merged 1 commit into from Jul 11, 2019
Merged

pythonPackages.swagger-spec-validator: init at 2.4.3 #62661

merged 1 commit into from Jul 11, 2019

Conversation

vanschelven
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vanschelven vanschelven requested a review from FRidh as a code owner June 4, 2019 13:02
@vanschelven vanschelven force-pushed the swagger-spec-validator branch 3 times, most recently from 8521dff to f6c108c Compare June 5, 2019 08:03
@risicle
Copy link
Contributor

risicle commented Jun 5, 2019

Again, as in #62668, this isn't actually picking up any tests.

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK

@vanschelven
Copy link
Contributor Author

Tests are not packaged (excluded in setup.py); I've switched to doCheck=false

@risicle
Copy link
Contributor

risicle commented Jun 6, 2019

Tests are not packaged

In these cases I tend to use fetchFromGitHub to grab the source instead - usually the authors keep tags corresponding to version numbers.

@worldofpeace
Copy link
Contributor

I'd like to also mention, if the recent python packaging pr's are for a common feature or goal you can group them into one pr. That allows the reviews to converge quickly.

@vanschelven
Copy link
Contributor Author

Tests are not packaged

In these cases I tend to use fetchFromGitHub to grab the source instead - usually the authors keep tags corresponding to version numbers.

Done, with running tests now.

worldofpeace
worldofpeace approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds on all interpreters in nixpkgs, pushed nitpicks.

@worldofpeace worldofpeace merged commit e494735 into NixOS:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vanschelven @risicle @worldofpeace