bro: 2.5.5 -> 2.6.2 #62695
Closed
bro: 2.5.5 -> 2.6.2 #62695
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security fix release mentioned at top of notes, FWIW: https://raw.githubusercontent.com/zeek/zeek/bb979702cf9a2fa67b8d1a1c7f88d0b56c6af104/NEWS
ofborg
bot
added
10.rebuild-darwin: 0
|
Initial Feedback:
|
|
Oh, and you need to add |
|
BTW this builds on darwin if you enable the platform. Tested on macos 10.13. |
oxzi
reviewed
Jul 15, 2019
| @@ -2,16 +2,20 @@ | |||
| , geoip, gperftools, python, swig }: | |||
|
|
|||
| stdenv.mkDerivation rec { | |||
| name = "bro-2.5.5"; | |||
| name = "bro-2.6.2"; | |||
|
|
|||
| src = fetchurl { | |||
| url = "https://www.bro.org/downloads/${name}.tar.gz"; | |||
There was a problem hiding this comment.
With the renaming of the project, this address now forwards to the new domain. So perhaps the domain should already be updated.
url = "https://www.zeek.org/downloads/${name}.tar.gz";| }; | ||
|
|
||
| nativeBuildInputs = [ cmake flex bison file ]; | ||
| buildInputs = [ openssl libpcap perl zlib curl geoip gperftools python swig ]; | ||
|
|
||
| # Indicate where to install the python bits, since it can't put them in the "usual" | ||
| # locations as those paths are read-only. | ||
| cmakeFlags = [ "-DPY_MOD_INSTALL_DIR=${placeholder "out"}/${python.sitePackages}" ]; |
There was a problem hiding this comment.
Most Zeek/Bro installation come with the auxiliary tools, like bro-cut. Thus, the "-DINSTALL_AUX_TOOLS:BOOL=true" cmake flag should be added.
|
The renaming from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Security fix release mentioned at top of notes, FWIW:
https://raw.githubusercontent.com/zeek/zeek/bb979702cf9a2fa67b8d1a1c7f88d0b56c6af104/NEWS
Seems reasonable but if anyone actually familiar can test or otherwise
review that'd be appreciated!
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)