spidermonkey_60: 60.4.0 -> 60.7.0 #62691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks! |
|
@abbradar this does not build, as https://github.com/NixOS/nixpkgs/runs/141869744 indicates |
|
Hm, I must've been extremely distracted - I remember seeing successful ofborg build. Thanks for noticing. |
|
I reverted it for now ; I'll check errors more thoroughly later today. |
|
Sorry, the patch just needs to be dropped.
I did that when upgrading to intermediate version a while back
but missed when gathering for the PR.
(so it builds and works for me, but...d'oh)
…On Wed, 05 Jun 2019 06:08:06 -0700, Nikolay Amiantov ***@***.***> wrote:
I reverted it for now ; I'll check errors more thoroughly later today.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#62691 (comment) part: text/html
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
(This should generally track firefox-esr's version, right?)
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)