New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qtikz: unstable-20161122 -> 0.12 #62733
Conversation
Updated and rebased :-) |
license = licenses.gpl2; | ||
platforms = platforms.linux; | ||
maintainers = [ maintainers.layus ]; | ||
longDescription = '' | ||
You will also need a working *tex installation in your PATH, containing at least `preview` and `pgf`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not add them to path like gnuplot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because you cannot install latex packages "alone", you need something alogn the lies of texlive.withPackages
. We could provide a minimal working environment, but that would be mostly redundant with the user-defined one. Or maybe not ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't fully understand how texlive works in nixos but it is my understanding that adding a minimal texlive to this package wouldn't interfere much / increase store size if the user had a bigger/different texlive installed. If that is the case it would surely be worth including this minimal texlive and using makeWrapper to include it in the path. Apologies if my rambling doesn't make a lot of sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This remark makes total sense. My concern is that providing a minimal environment will make qtikz break later on, in unexpected ways. I think it is better to provide none, so that users get a proper error on the first use, and know that they have to provide a working TeX environment.
Providing a default environment would help, but then users will start wondering how to add packages to it. They may also have issues to know if they are using their own environment instead of the default one, etc.
But it kind of boils down to personal tastes. My use of qtikz (and from the time it has been broken, it seems I am the only user) is to generate figures that will be included in larger, complete documents. These figures use packages from that document, and extra tikz libraries from my tex install. A default tex installation is nearly useless for me and would, as stated above, be more confusing that helpful.
This question has a broader scope than this lone package. I guess it arises in other applications. I should maybe start a ML thread...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I agree with you. I don't understand why this would cause the package to break but I had more of a think and I can see the situation where someone would like to use qtikz and write something that requires extra tex packages (say for the labels). In this case it makes most sense that qtikz uses whatever tex environment the user wants to use. Also I assume anyone using this program will have tex installed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel the ideal is to somehow use a "union" of a minimal tex needed for this to work and the current environment tex though I don't think this is possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel the ideal is to somehow use a "union" of a minimal tex needed for this to work and the current environment tex though I don't think this is possible
Yes, that would be the best, but I know of no way to do that.
I don't understand why this would cause the package to break
Well, maybe I am over-cautious here.
Okay. For me this is ready to merge. The issue raised by @jtojnar (#62733 (comment)) is still open, but I think that the current situation is the best compromise. |
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/how-to-depend-on-latex-environments/3155/1 |
@FRidh care to merge this one ? |
Thanks. |
Motivation for this change
No update in two years, and a broken package ;-)
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)