Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: sh: fix (patch a test to be able to install again) #62667

Merged
merged 1 commit into from Jun 5, 2019
Merged

python: sh: fix (patch a test to be able to install again) #62667

merged 1 commit into from Jun 5, 2019

Conversation

vanschelven
Copy link
Contributor

Motivation for this change

On NixOS 19.03, one test failed because of an extra LC_CTYPE=C.UTF-8
'cruft variable. The test has been patched to remove this variable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vanschelven vanschelven requested a review from FRidh as a code owner June 4, 2019 15:05
@marsam
Copy link
Contributor

marsam commented Jun 5, 2019

@GrahamcOfBorg build pythonPackages.sh python3Packages.sh

@marsam marsam merged commit d3c9e5e into NixOS:master Jun 5, 2019
@marsam
Copy link
Contributor

marsam commented Jun 5, 2019

Thank you @vanschelven!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vanschelven @marsam