Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mate.mate-user-share: add dbus-glib dependency #62673

Merged
merged 1 commit into from Jun 5, 2019
Merged

mate.mate-user-share: add dbus-glib dependency #62673

merged 1 commit into from Jun 5, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jun 4, 2019 •
edited

Motivation for this change
  • Since version 1.22.0 mate-user-share depends on dbus-glib.
  • libxml2 is needed only at compilation time.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo
Copy link
Contributor Author

romildo commented Jun 4, 2019

@GrahamcOfBorg build mate.mate-user-share

@worldofpeace
Copy link
Contributor

Huh, why would they switch to using a deprecated API. Looking at the history it should have depended on this since they forked.

worldofpeace
worldofpeace approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though it looks like you might have made the commit within nix-review so the authorship is incorrect.

@romildo romildo merged commit b7aaf96 into NixOS:master Jun 5, 2019
@romildo romildo deleted the upd.mate branch June 5, 2019 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @worldofpeace