Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Luazlib renamed to lua-zlib + update + move to generated #62751

Merged
merged 2 commits into from Jun 6, 2019
Merged

Luazlib renamed to lua-zlib + update + move to generated #62751

merged 2 commits into from Jun 6, 2019

Conversation

teto
Copy link
Member

@teto teto commented Jun 6, 2019 •
edited

Motivation for this change

As most packages are generated, better stick with the (official) luarocks name. Only sile used luazlib so it shouldn't warrant an alias yet.

I added a column to track maintainers in maintainers/scripts/luarocks-packages.csv.
It's not used yet but I will update the script soon to reflect the change.

Tested binaries with nix-review.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

teto added 2 commits June 6, 2019 12:12
@teto
luaPackages.lua-zlib: 1.1 -> 1.2
dbf4c80 
Renamed from luazlib to luarocks name lua-zlib.
Move to generated.
@teto
luarocks-packages.csv: track maintainers in column
9a3f13f 
luarocks-nix doesn't use yet but it will in next update.
@teto teto merged commit 8b3d0b0 into NixOS:master Jun 6, 2019
@teto teto deleted the luazlib branch June 6, 2019 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: lua 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@teto