adrdox: init at v1.0.0 #62739
adrdox: init at v1.0.0 #62739
Conversation
|
adrdox got a proper version number now. I’ll update the PR and address the review comments this weekend. |
|
I've addressed each remark and squashed. |
| @@ -948,6 +948,11 @@ | |||
| github = "chiiruno"; | |||
| name = "Okina Matara"; | |||
| }; | |||
| chloekek = { | |||
There was a problem hiding this comment.
Please rewrite your git history into 2 single commits. The first commit should be adding this entry to maintainer-list.nix and the second should be the other commits squashed into 1.
| + dmd doc2.d latex.d cgi.d comment.d stemmer.d dom.d script.d jsvar.d html.d color.d -J. $(LIBDPARSE) -g # -version=std_parser_verbose | ||
| #dmd -of/var/www/dpldocs.info/locate locate.d dom.d stemmer.d cgi -J. -version=fastcgi -m64 -debug | ||
| locate: | ||
| dmd -of/var/www/dpldocs.info/locate locate.d dom.d stemmer.d cgi -J. -version=fastcgi -m64 -debug postgres.d database.d -L-L/usr/local/pgsql/lib |
There was a problem hiding this comment.
Is this patch written by you or did you find it upstream somewhere? Is there an issue upstream to fix this? A patch like this ideally doesn't belong in nixpkgs but should be in upstream.
|
|
||
| stdenv.mkDerivation rec { | ||
| pname = "adrdox"; | ||
| version = "v1.0.0"; |
There was a problem hiding this comment.
The version part of the name attribute must start with a digit (following a dash) — e.g., "hello-0.3.1rc2".
| src = fetchFromGitHub { | ||
| owner = "adamdruppe"; | ||
| repo = "adrdox"; | ||
| rev = version; |
There was a problem hiding this comment.
Given comment above this should be rev = "v${version}";.
|
|
||
| src = fetchFromGitHub { | ||
| owner = "adamdruppe"; | ||
| repo = "adrdox"; |
There was a problem hiding this comment.
repo = pname; is a fairly common thing to do.
Adding a package for the adrdox documentation generator for D.
|
Thank you for your contributions.
|
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing due to inactivity from author. |
Adding a package for the adrdox documentation generator for D.
Motivation for this change
I like this tool and it wasn't in Nixpkgs so I added it to Nixpkgs. It is used by several D projects for generating HTML documentation from source code.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)