Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-quick-stats: init at 2.0.8 #62730

Closed
wants to merge 2 commits into from
Closed

git-quick-stats: init at 2.0.8 #62730

wants to merge 2 commits into from

Conversation

wiedzmin
Copy link

@wiedzmin wiedzmin commented Jun 5, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

alexarice
alexarice reviewed Jun 5, 2019
View reviewed changes
pkgs/applications/version-management/git-and-tools/default.nix Outdated Show resolved Hide resolved
pkgs/applications/version-management/git-and-tools/git-quick-stats/default.nix Outdated Show resolved Hide resolved
pkgs/applications/version-management/git-and-tools/git-quick-stats/default.nix Outdated Show resolved Hide resolved
pkgs/applications/version-management/git-and-tools/git-quick-stats/default.nix Outdated Show resolved Hide resolved
pkgs/applications/version-management/git-and-tools/git-quick-stats/default.nix Outdated Show resolved Hide resolved
pkgs/applications/version-management/git-and-tools/git-quick-stats/default.nix Outdated Show resolved Hide resolved
pkgs/applications/version-management/git-and-tools/git-quick-stats/default.nix Outdated Show resolved Hide resolved
jtojnar
jtojnar requested changes Jun 5, 2019
View reviewed changes
pkgs/applications/version-management/git-and-tools/git-quick-stats/default.nix
src = fetchFromGitHub {
owner = "arzzen";
repo = pname;
rev = "c11bce17bdb1c7f1272c556605b48770646bf807";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make future updates easier:

Suggested change
rev = "c11bce17bdb1c7f1272c556605b48770646bf807";
rev = version;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, missed existing tag, thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not seem to be resolved

@devhell
Copy link
Contributor

devhell commented Jun 9, 2019

Is this a duplicate of #62440?

@vcunat
Copy link
Member

vcunat commented Jun 9, 2019

It is... so if you still want to improve the merged expression in some way (e.g. add yourself to maintainers), I suggest you rebase or start over and force-push this branch.

@wiedzmin wiedzmin closed this Jun 12, 2019
@wiedzmin
Copy link
Author

wiedzmin commented Jun 12, 2019 •
edited

Tool emerged in nixos-unstable branch by another path, so I'm closing this PR, as I had no time to address it in recent days. Anyway thanks you all for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar requested changes

@alexarice alexarice alexarice left review comments

Assignees
No one assigned
Labels
2.status: work-in-progress 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wiedzmin @devhell @vcunat @jtojnar @alexarice @Janik-Haag