Load Ahem as a webfont everywhere (part 2) #17173
Conversation
This change updates a large number of reftests to link to the `/fonts/ahem.css` stylesheet. Each file contains a single additional line before the first `<style>` element: ``` <link rel="stylesheet" type="text/css" href="/fonts/ahem.css" /> ```
stats make more sense (2439 files, 2439 insertions).
wpt-pr-bot
added
compat
css-backgrounds
css-contain
css-flexbox
css-fonts
css-grid
css-masking
css-multicol
css-overflow
css-paint-api
css-position
css-pseudo
css-rhythm
css-shapes
css-sizing
css-text
css-transforms
css-ui
css-values
css-writing-modes
CSS2
cssom
html
infra
reference
svg
vendor-imports
webvtt
labels
wpt-pr-bot
requested review from
nikosandronikos,
nox,
plinss,
r12a,
rachelandrew,
shans,
silviapfeiffer,
svgeesus,
svillar,
tabatkins,
upsuper,
zcorpan and
zqzhang
and removed request for
lilles,
litherum,
miketaylr,
mrego and
mstensho
Yep, fair point. I'll cover those ones in a separate pass. The final step to this whole migration will be to stop installing Ahem on CI, which should uncover any other test that might have been missed. |
|
I'm curious about what is the benefit of doing this for a lot of tests that don't need the Ahom font? |
The intent is that this only happened for tests that do use Ahem. Do you have examples where the webfont was added but isn't required? I think it would make sense to file a separate issue about that. |
|
@jgraham Ah, ok. In that case it makes more sense. I thought i spotted a few files that didn't use the font, but i think it may have been a lapse in memory combined with an inability to see the relevant lines in the diff. |
Manual import pending resolution of issue 973057. This includes a lot of changes from an Ahem PR: web-platform-tests/wpt#17173 Using wpt-import in Chromium fc41cdf. With Chromium commits locally applied on WPT: e90c6ef "NG/DL: Implement size containment (and display lock) for NG fieldset algo" 9e3affd "Ship `referer` header length limitation." 723f9a7 "Prevent leaking Sec-CH-/Sec-Fetch- Request Headers on HTTPS Downgrade Redirects." TBR=robertma@chromium.org No-Export: true Bug: 973057 Change-Id: Ie68f8105542eddae1ce7ec4a3f94b691aaee535a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653228 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#668344}
|
@LukeZielinski also just realised you used a case-sensitive grep, which missed a lot of font: ahem (font names are case-insensitive!). in WPT gives 1320 lines (whoops!) |
This change updates a large number of reftests to link to the `/fonts/ahem.css` stylesheet. Each file contains a single additional line before the first `<style>` element: ``` <link rel="stylesheet" type="text/css" href="/fonts/ahem.css" /> ```
Manual import pending resolution of issue 973057. This includes a lot of changes from an Ahem PR: web-platform-tests/wpt#17173 Using wpt-import in Chromium b7fcb50 [formerly fc41cdff62ab94a688c3b6ced98fc66e236b4fa2]. With Chromium commits locally applied on WPT: 1e8b8b0 [formerly e90c6ef049] "NG/DL: Implement size containment (and display lock) for NG fieldset algo" 7648c26 [formerly 9e3affdd55] "Ship `referer` header length limitation." a663fae [formerly 723f9a7899] "Prevent leaking Sec-CH-/Sec-Fetch- Request Headers on HTTPS Downgrade Redirects." TBR=robertma@chromium.org No-Export: true Bug: 973057 Change-Id: Ie68f8105542eddae1ce7ec4a3f94b691aaee535a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653228 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#668344} Former-commit-id: 6208d2dfdf90a936fe69104f25ee517253496525
This change updates a large number of reftests to link to the
/fonts/ahem.cssstylesheet. Each file contains a single additionalline before the first
<style>element: