Do not resume a suspended BaseAudioContext when AudioWorklet starts #16303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 9, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1560140
branch
from
52e440f
to
4bad4ad
Compare
When AudioWorklet.addModule() activates the worklet thread, it re-starts the destination handler even when the context is suspended. This CL fixes the bug by restarting destination only when the context is in the "running" state. Bug: 950997 Test: external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-suspend.https.html Change-Id: I0b44e3fca23bd069fac21f709fc665e8eacc4dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560140 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#649303}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1560140
branch
from
4bad4ad
to
cd9fcb0
Compare
|
The test author will send a follow-up fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When AudioWorklet.addModule() activates the worklet thread, it
re-starts the destination handler even when the context is suspended.
This CL fixes the bug by restarting destination only when the context
is in the "running" state.
Bug: 950997
Test: external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-suspend.https.html
Change-Id: I0b44e3fca23bd069fac21f709fc665e8eacc4dd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560140
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649303}