Add ESD protection diodes for AUX pins too #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcan |
|
Ah, I missed this somehow, sorry. I have no objection to the idea; @whitequark considered it not worth doing, but having the footprints won't hurt, so yeah, we can always DNP them. As for review, please make sure the two footprints are at equal distance from the centerline of the board, just like everything else on that side of the board :-) |
|
I updated my branch to current Glasgow upstream. The two diode footprints are now placed symmetrical to the centerline of the board. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it might make sense to give the AUX pins the same level of esd protection than the io banks and sync. I used the same tvs diode type that is already used for sync.
If you don't think the added cost is worth it for a connector unpopulated by default, you could DNP them but keep the footprints for people who want to populate their aux.