Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pinentry: remove GTK3 dependency #59190

Merged
merged 1 commit into from Apr 9, 2019
Merged

pinentry: remove GTK3 dependency #59190

merged 1 commit into from Apr 9, 2019

Conversation

adrianparvino
Copy link
Contributor

@adrianparvino adrianparvino commented Apr 8, 2019 •
edited

Motivation for this change

GTK3 dependency adds 100 MB to the closure of pinentry_ncurses.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Apr 8, 2019

Yeah, we missed this in c1599d2#diff-2c82bb4284e9f0d52c010f7d29cf4cd4.

@adrianparvino adrianparvino changed the title pinentry_ncurses: remove GTK3 dependency pinentry: remove GTK3 dependency Apr 8, 2019
@adrianparvino
Copy link
Contributor Author

@jtojnar I've updated it.

@flokli
Copy link
Contributor

flokli commented Apr 9, 2019

related: #49270

@jtojnar jtojnar changed the base branch from master to staging April 9, 2019 20:26
@flokli flokli merged commit 582c8c5 into NixOS:staging Apr 9, 2019
@adrianparvino adrianparvino deleted the pinentry-remove-gtk3-dep branch April 9, 2019 23:08
@jtojnar jtojnar mentioned this pull request Apr 15, 2019
Closed
@flokli flokli mentioned this pull request May 25, 2019
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adrianparvino @jtojnar @flokli @GrahamcOfBorg