Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6618: Viewport vehicle draw flickering #7475

Closed

Conversation

JGRennison
Copy link
Contributor

Fix incorrect bounds check in ViewportAddVehicles in the case where the
viewport width or height is less than the hash wraparound
distance, however the two bounds still map to the same hash bucket
due to discarding the lower coordinate bits, such that the intermediary
hash buckets are incorrectly not iterated.

Fix incorrect bounds check in ViewportAddVehicles in the case where the
viewport width or height is less than the hash wraparound
distance, however the two bounds still map to the same hash bucket
due to discarding the lower coordinate bits, such that the intermediary
hash buckets are incorrectly not iterated.
@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label Apr 6, 2019
@PeterN
Copy link
Member

PeterN commented Apr 7, 2019

How can I see the difference this makes? I've never noticed vehicles flickering.

@stale
Copy link

stale bot commented May 7, 2019

This pull request has been automatically marked as stale because it has not had any activity in the last month.
Please feel free to give a status update now, ping for review, or re-open when it's ready.
It will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale Stale issues label May 7, 2019
@stale stale bot closed this May 14, 2019
@LordAro LordAro removed the backport requested This PR should be backport to current release (RC / stable) label Sep 14, 2019
@JGRennison JGRennison deleted the viewport-hash-scan-bounds-fix branch January 9, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants