Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flightgear & simgear: 2018.2.2 -> 2018.3.1 #59236

Merged
merged 2 commits into from Apr 10, 2019
Merged

flightgear & simgear: 2018.2.2 -> 2018.3.1 #59236

merged 2 commits into from Apr 10, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Apr 9, 2019 •
edited

Motivation for this change

#52020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse changed the title flightgear & simgear: 2018.2.2 -> 2018.3.1 WIP: flightgear & simgear: 2018.2.2 -> 2018.3.1 Apr 10, 2019
@aanderse
Copy link
Member Author

@teto this should build for you now, at least on x86_64-linux...

@aanderse aanderse changed the title WIP: flightgear & simgear: 2018.2.2 -> 2018.3.1 flightgear & simgear: 2018.2.2 -> 2018.3.1 Apr 10, 2019
@teto
Copy link
Member

teto commented Apr 10, 2019

Why the ping ? because I subscribed to notifications xD ? I can try to build it if you want.

@aanderse
Copy link
Member Author

Why the ping ? because I subscribed to notifications xD ? I can try to build it if you want.

oops! totally meant for @timokau and not you. sorry for confusion!

@7c6f434c
Copy link
Member

@GrahamcOfBorg build flightgear

@7c6f434c 7c6f434c merged commit cd2a342 into NixOS:master Apr 10, 2019
@matthiasbeyer matthiasbeyer mentioned this pull request Apr 10, 2019
Closed
10 tasks
@aanderse
Copy link
Member Author

@GrahamcOfBorg build flightgear

After seeing how long it took on my machine I didn't even bother ...

@aanderse aanderse deleted the flightgear branch April 10, 2019 10:03
@7c6f434c
Copy link
Member

Well, the timeout was way later than the failures in the previous updates, so I did receive a confirmation that the previous ofBorg issues were not unique (an unsolved even by double update). Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aanderse @teto @7c6f434c @matthiasbeyer @worldofpeace @GrahamcOfBorg