codimd: js-sequence-diagrams: use git source rather than the NPM tarball #59194
Conversation
|
@GrahamcOfBorg test codimd This should also be backported to |
|
ok, so now there's https://github.com/codimd/server/pull/41/files which uses a fork of |
Ma27
changed the title
|
This doesn't seem to be possible right now as |
Ma27
changed the title
It seems as NPM just removed the tarballs of the unpublished package, hence `codimd` isn't buildable. The sources for the package are available on github[1] and fix the build. For further information about the `js-sequence-diagrams` workarounds, please refer to 5feec42. [1] https://github.com/Moeditor/js-sequence-diagrams
Ma27
force-pushed
the
fix-js-sequence-diagrams-source
branch
from
9d688b1
to
c68bc18
Compare
|
Updated the commit message to fix a small typo. @marsam are you still okay with this? :) |
|
Just had a short chat with @WilliButz. We both agreed that this is the best solution for now and unless I hear otherwise, I'd merge/backport the fix tonight. I know that this isn't the best solution, but it should be fine for now. As mentioned in original issue, it's planned to switch to |
|
As announced, I'll merge this for now. As soon as @WilliButz or I have sufficient time, the bump to 1.3 with |
|
Backported as 0b89775. |
Motivation for this change
It seems as NPM just removed the tarballs of the unpublished package,
hence
codimdisn't buildable. The sources for the package areavailable on github[1] and fix the build.
For further information about the
js-sequence-diagramsworkarounds,please refer to 5feec42.
[1] https://github.com/Moeditor/js-sequence-diagrams
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)