-
-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Moveable depots #6328 #7051
Conversation
Gave this 5 minutes of testing, initial impressions are that all worked as expected. Vehicle orders are preserved for up to 1 month, then invalidated if the depot isn't rebuilt by then. The search radius for 'preserve depot' seems to be about 8 tiles or so. In use, it's pretty neat. FWIW, adf88 considered there was more to do on the original patch #6328 (comment) However it might be useful as is. |
From CI: 2019-01-12T22:39:23.2400344Z Running ai/regression/tst_regression... failed! |
First regression error is at main.nut:1062, it's because the rail depot list is empty but it shouldn't as a rail depot as been built. Second regression error is at main.nut:1167, it's because the road depot list actually contains the water depot list. |
1232d3c
to
2fc136e
Compare
@@ -2092,7 +2078,7 @@ bool UpdateOrderDest(Vehicle *v, const Order *order, int conditional_depth, bool | |||
v->IncrementRealOrderIndex(); | |||
} else { | |||
if (v->type != VEH_AIRCRAFT) { | |||
v->SetDestTile(Depot::Get(order->GetDestination())->xy); | |||
v->SetDestTile(v->GetOrderDepotLocation(order->GetDestination())); | |||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Eddi-z will you update this? |
bf40b42
to
df86ea9
Compare
So, i resolved the saveload part, but the viewport part is way over my head with the kdtree changes. |
I rebased this branch and updated it to use Kdtree here: https://github.com/nielsmh/OpenTTD/tree/movable-depots Update: Got an ok on IRC. |
Found a crash:
Something to do with Order backups... |
Hi, there's been no activity on this for over 4 months. If no more effort will be put into this PR, it will be closed in the next week or so |
patch imported from flyspray
minor conflict resolved
savegame bump rebased
(TODO: put correct version info)now resolved with new saveload enumpatch queue seems "unclean" (partial patch did not compile, whole queue does)now resolved by reordering some patches