Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jazzy: 0.9.5 -> 0.9.6 #59145

Merged
merged 1 commit into from Apr 12, 2019
Merged

jazzy: 0.9.5 -> 0.9.6 #59145

merged 1 commit into from Apr 12, 2019

Conversation

lilyball
Copy link
Member

@lilyball lilyball commented Apr 8, 2019 •
edited

Motivation for this change

https://github.com/realm/jazzy/releases/tag/v0.9.6

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/rubygem-conflicts-with-ruby-packages/2636/5

@lilyball
jazzy: 0.9.5 -> 0.9.6
b1bb10b 
Also switch from `bundlerEnv` to `bundlerApp`.
@lilyball
Copy link
Member Author

I've updated this PR to use bundlerApp instead of bundlerEnv.

I also accidentally rebased it on top of 8e9796c (from #59252) temporarily, hence the automatic code review request, but undid that as that commit isn't applicable to this PR.

@alyssais
Copy link
Member

@GrahamcOfBorg build jazzy

@alyssais alyssais merged commit bd5afce into NixOS:master Apr 12, 2019
@lilyball lilyball deleted the jazzy branch April 13, 2019 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@alyssais alyssais Awaiting requested review from alyssais

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lilyball @nixos-discourse @alyssais @matthiasbeyer @GrahamcOfBorg