Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cura: support plugins, add octoprint-plugin #59159

Merged
merged 1 commit into from Jun 13, 2019
Merged

cura: support plugins, add octoprint-plugin #59159

merged 1 commit into from Jun 13, 2019

Conversation

betaboon
Copy link
Contributor

@betaboon betaboon commented Apr 8, 2019

Motivation for this change

I wanted to be able to install plugins.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

gebner
gebner reviewed Jun 1, 2019
View reviewed changes
pkgs/applications/misc/cura/plugins.nix
meta = with stdenv.lib; {
description = "Enables printing directly to OctoPrint and monitoring the process";
homepage = https://github.com/fieldOfView/Cura-OctoPrintPlugin;
license = licenses.agpl3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add yourself as a maintainer here.

pkgs/applications/misc/cura/plugins.nix Outdated

meta = with stdenv.lib; {
description = "Enables printing directly to OctoPrint and monitoring the process";
homepage = https://github.com/fieldOfView/Cura-OctoPrintPlugin;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage = https://github.com/fieldOfView/Cura-OctoPrintPlugin;
homepage = "https://github.com/fieldOfView/Cura-OctoPrintPlugin";

URLs should be quoted now: NixOS/rfcs#45

pkgs/applications/misc/cura/plugins.nix Outdated
src = fetchFromGitHub {
owner = "fieldOfView";
repo = "Cura-OctoPrintPlugin";
rev = version;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Cura-OctoPrintPlugin repository, 3.5 is a branch and not a tag. That is, it changes regularly and does not point to a fixed commit. Please just put the latest revision here.

@gebner
Copy link
Member

gebner commented Jun 1, 2019

Sorry, I completely missed this. I tested it with cura.override { plugins = [ curaPlugins.octoprint ]; }, and I can successfully connect to my octoprint server.

Unfortunately there doesn't seem to be any easier way to register the plugins since cura looks for them in the installation directory. But fortunately building cura is cheap, it's just copying python files.

@gebner gebner merged commit 958350f into NixOS:master Jun 13, 2019
@betaboon
Copy link
Contributor Author

@gebner thanks for taking care of this. i have been away for a while and haven't found the time to take care of your notes. sorry for that.

@betaboon betaboon deleted the cura-plugins branch June 14, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gebner gebner gebner left review comments

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@betaboon @gebner @GrahamcOfBorg