Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.appindicator: 23.1 -> 28 #59239

Closed
wants to merge 1 commit into from
Closed

gnomeExtensions.appindicator: 23.1 -> 28 #59239

wants to merge 1 commit into from

Conversation

jonafato
Copy link
Contributor

Motivation for this change

Update the GNOME appindicator support extension to the latest version.
See the GitHub page for the full changelog:
ubuntu/gnome-shell-extension-appindicator@v23...v28

Targeting staging with this PR until GNOME 3.32 lands in master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you set platforms in meta like?

platforms = gnome3.gnome-shell.meta.platforms;

Also GNOME 3.32 is in staging-next so I'll merge this there.
(no need to change base, I'll merge manually)

@jonafato
gnomeExtensions.appindicator: 23.1 -> 28
daed3c9 
Update the GNOME appindicator support extension to the latest version.
See the GitHub page for the full changelog:
ubuntu/gnome-shell-extension-appindicator@v23...v28
@jonafato jonafato force-pushed the gnomeExtensions.appindicator-28 branch from f3277f5 to daed3c9 Compare April 10, 2019 03:26
@jonafato
Copy link
Contributor Author

@worldofpeace Thanks for the quick feedback, done.

@worldofpeace
Copy link
Contributor

Merged in 9ddf85d

Thanks @jonafato ❇️

@jonafato jonafato deleted the gnomeExtensions.appindicator-28 branch April 10, 2019 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonafato @worldofpeace @GrahamcOfBorg