Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take the engine thrust limiter into account in manœuvres #2128

Closed
Kinexity opened this issue Apr 9, 2019 · 5 comments · Fixed by #2143 or #2228
Closed

Take the engine thrust limiter into account in manœuvres #2128

Kinexity opened this issue Apr 9, 2019 · 5 comments · Fixed by #2143 or #2228
Assignees
Milestone

Comments

@Kinexity
Copy link

Kinexity commented Apr 9, 2019

Would this be possible to implement inclusion of engine's thrust offset in maneuver planning? For ex. it's hard to set capture burn correctly from interplanetary trajectory with ion engine when you can't supply enough energy.

@pleroy
Copy link
Member

pleroy commented Apr 13, 2019

You'll need to provide more details as I have no idea what you are asking. Specifically, what do you mean by "thrust offset"? How does that relate to ion engines?

@Kinexity
Copy link
Author

I meant "thrust limiter" (i'm not native english speaker so mistakes happen). In flight planning, when you create a maneuver it's duration is calculated as if you were using 100% thrust of engines, which is the opposite to what stock maneuvers do (they take into account previously set thrust limit). What I would like to propose as a feature is to make Principia maneuver planning do the same (so if someone for ex. would set thrust limiter to 50 their maneuver's duriation and trajectory would have been calculated with that taken into account).

@pleroy pleroy changed the title Engine thrust offset with maneuver planning (feature request) Take the engine thrust limiter into account in manœuvres Apr 13, 2019
@pleroy
Copy link
Member

pleroy commented Apr 13, 2019

I see, thanks for the clarification.

@pleroy
Copy link
Member

pleroy commented Apr 28, 2019

Reopening as we had to revert the change while building Fáry: the API we use didn't exist prior to 1.5.1.

Also, we should do the same for RCS.

@pleroy pleroy reopened this Apr 28, 2019
@pleroy pleroy modified the milestones: Fáry, Fatou Apr 28, 2019
@pleroy pleroy modified the milestones: Fatou, Fermat May 25, 2019
@pleroy
Copy link
Member

pleroy commented May 25, 2019

This won't be fixed in Fatou (June) because Fatou will be the last version supporting 1.3.1. This bug will likely be fixed in Fermat (July) once we stop supporting versions prior to 1.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants