Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sl: add missing man pages #59109

Merged
merged 1 commit into from Apr 7, 2019
Merged

sl: add missing man pages #59109

merged 1 commit into from Apr 7, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Man pages were missing.

Cc: @eyJhb

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eyJhb
Copy link
Member

eyJhb commented Apr 7, 2019 •
edited

@pSub @peterhoeg just a minor thing looking at this, the fetchFromGit block shouldn't be aligned using spaces, see here - #58970 (comment).

Else LGTM 🐬

@peterhoeg peterhoeg merged commit 8466ad7 into NixOS:master Apr 7, 2019
@peterhoeg peterhoeg deleted the f/sl branch April 7, 2019 13:15
@peterhoeg peterhoeg restored the f/sl branch April 7, 2019 14:43
@peterhoeg peterhoeg deleted the f/sl branch April 8, 2019 11:59
@infinisil infinisil mentioned this pull request Apr 22, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub pSub approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peterhoeg @eyJhb @pSub @GrahamcOfBorg