Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mixxx: 2.1.5 -> 2.2.0 (#53643) - QT5 version #59108

Merged
merged 1 commit into from Apr 9, 2019
Merged

mixxx: 2.1.5 -> 2.2.0 (#53643) - QT5 version #59108

merged 1 commit into from Apr 9, 2019

Conversation

willtim
Copy link
Contributor

@willtim willtim commented Apr 7, 2019

Motivation for this change

Move Mixxx from older QT4 version to latest QT5 version

Things done

Tested compilation under NixOS and basic functionality.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@willtim willtim mentioned this pull request Apr 7, 2019
Closed
matthiasbeyer
matthiasbeyer requested changes Apr 7, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you merging master?

@willtim
Copy link
Contributor Author

willtim commented Apr 7, 2019

removed the merge commit

matthiasbeyer
matthiasbeyer approved these changes Apr 7, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me, but I do not have a strong enough machine right now to test-build this.

@markuskowa
Copy link
Member

@GrahamcOfBorg build mixxx

@markuskowa
Copy link
Member

I can build it locally on x86_64. However, some pulseaudio bug crashes the virtual box, where I execute mixxx. @willtim could you successfully run it?

@markuskowa markuskowa self-assigned this Apr 7, 2019
@willtim
Copy link
Contributor Author

willtim commented Apr 9, 2019

I can build it locally on x86_64. However, some pulseaudio bug crashes the virtual box, where I execute mixxx. @willtim could you successfully run it?

I can successfully run it yes, but QT5 does have a lot of dynamic runtime dependencies and I cannot be 100% confident that it will still run without some any other QT5 app in my environment (!)
The porting to QT5 was fairly mechanical and straightforward though.

@markuskowa markuskowa merged commit 5f62136 into NixOS:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@aszlig aszlig Awaiting requested review from aszlig

Assignees

@markuskowa markuskowa

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@willtim @markuskowa @matthiasbeyer @GrahamcOfBorg