Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.zerorpc: init at 0.6.1 #59102

Merged
merged 1 commit into from Apr 9, 2019
Merged

pythonPackages.zerorpc: init at 0.6.1 #59102

merged 1 commit into from Apr 9, 2019

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Apr 7, 2019

Motivation for this change

A simple, easy-to-use RPC implementation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji xeji requested a review from FRidh as a code owner April 7, 2019 10:29
@xeji
Copy link
Contributor Author

xeji commented Apr 7, 2019

@GrahamcOfBorg build python3.pkgs.zerorpc python2.pkgs.zerorpc

@xeji xeji merged commit d6afe8c into NixOS:master Apr 9, 2019
@xeji xeji deleted the p/zerorpc branch April 9, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @matthiasbeyer @GrahamcOfBorg