Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell-generic-builder: backport to 19.03 add option to disable library-for-ghci #59146

Merged
merged 1 commit into from Apr 11, 2019
Merged

haskell-generic-builder: backport to 19.03 add option to disable library-for-ghci #59146

merged 1 commit into from Apr 11, 2019

Conversation

cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Apr 8, 2019 •
edited

Motivation for this change

This is a backport of #58743 to release-19.03.

The reason this was added to master is described in #58743. At work we are running into the bug described in #58743. Since we are following the release-19.03 branch, we'd like this to be backported. Then we can use it in our code-base to work around this bug.

Pinging @peti.

This shouldn't cause any recompilations to happen.

(cherry picked from commit b58ecf3)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout cdepillabout changed the title Add option to disable library-for-ghci in the generic haskell builder. haskell-generic-builder: backport to 19.03 add option to disable library-for-ghci Apr 8, 2019
@cdepillabout
Copy link
Member Author

@peti @basvandijk @matthewbauer Would someone be able to do a quick review of this and merge it in?

We'd like to use this at work without having to vendor the Haskell generic-builder.nix script. This change shouldn't cause any rebuilds.

matthewbauer
matthewbauer approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks harmless enough to me. Ping me if it's not merged in a week.

@peti peti merged commit 44588a4 into NixOS:release-19.03 Apr 11, 2019
@cdepillabout cdepillabout deleted the backport-library-for-ghci branch April 11, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti peti is a code owner

@ryantm ryantm Awaiting requested review from ryantm ryantm is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cdepillabout @matthewbauer @peti @GrahamcOfBorg