Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

powerline-go: 1.11.0 -> 1.12.1 #59222

Merged
merged 1 commit into from Apr 10, 2019
Merged

powerline-go: 1.11.0 -> 1.12.1 #59222

merged 1 commit into from Apr 10, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Apr 9, 2019 •
edited

Motivation for this change

Update powerline-go to the latest version

https://github.com/justjanne/powerline-go/releases/tag/v1.12.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

vdemeester
vdemeester approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xeji
xeji reviewed Apr 10, 2019
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check for updates in dependencies (deps.nix) ? There are usually some. It is recommended to do that even if the updated app builds fine.

There's a semi-automated process for updating deps.nix with go2nix, see https://nixos.org/nixpkgs/manual/#sec-language-go and https://github.com/kamilchm/go2nix .
(We also have vgo2nix for Go apps using Go modules, which doesn't apply here)

@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 10, 2019

@xeji Thanks for the review!
The dependencies (deps.nix) are updated.

@xeji
Copy link
Contributor

xeji commented Apr 10, 2019

Thank you!
@GrahamcOfBorg build powerline-go

@xeji xeji merged commit d7d5bab into NixOS:master Apr 10, 2019
@xrelkd xrelkd deleted the powerline-go branch April 10, 2019 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xrelkd @xeji @vdemeester @GrahamcOfBorg