Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging-19.03] containerd: 1.2.5 -> 1.2.6 #59226

Closed
wants to merge 1 commit into from
Closed

[staging-19.03] containerd: 1.2.5 -> 1.2.6 #59226

wants to merge 1 commit into from

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Apr 9, 2019 •
edited

Motivation for this change

Bump containerd to latest release with security fixes : 1.2.6 release notes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vdemeester
containerd: 1.2.5 -> 1.2.6
d3482fc 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@FRidh
Copy link
Member

FRidh commented Apr 9, 2019

Thanks for the PR. Changes in the release branches typically go via the master branch. Ensure the change is in master/staging-next/staging and then cherry-pick -x the change.

@vdemeester
Copy link
Member Author

@FRidh ah make sense 👼 I have a question with this then #59224 (as master is already using 1.2.x..)

@vdemeester
Copy link
Member Author

@FRidh I'll wait for #59223 to get merged then 🙃 . Should I close this one in the meantime ?

@xeji
Copy link
Contributor

xeji commented Apr 9, 2019

I have marked #59223 to be backported so this can be closed.

@xeji xeji closed this Apr 9, 2019
@vdemeester
Copy link
Member Author

@xeji thank you 😻

@vdemeester vdemeester deleted the 19.03-update-containerd branch April 9, 2019 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vdemeester @FRidh @xeji @GrahamcOfBorg