Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/glib-networking: init #59185

Merged
merged 2 commits into from Apr 15, 2019
Merged

nixos/glib-networking: init #59185

merged 2 commits into from Apr 15, 2019

Conversation

worldofpeace
Copy link
Contributor

Note that we were previously didn't have glib-networking
in systemd.packages so the PacRunner was non-functional.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

I'm not against doing this, but I wonder how useful glib-networking is as a standalone module? I mean most users just want gnome they aren't going to care about fine tuned things like glib networking service. Perhaps there is some useful part in making things more modular though. But until we have something like NixOS/rfcs#22 there will be a cost for new modules (albeit very small).

@worldofpeace
Copy link
Contributor Author

I'm not against doing this, but I wonder how useful glib-networking is as a standalone module? I mean most users just want gnome they aren't going to care about fine tuned things like glib networking service. Perhaps there is some useful part in making things more modular though. But until we have something like NixOS/rfcs#22 there will be a cost for new modules (albeit very small).

I have the same gripe that I don't feel it's useful as a standalone module.
I mainly just want to share this configuration across the multiple desktop modules that need it, and be able to change it in one place.

@worldofpeace
nixos/glib-networking: init
b0e9f85 
Note that we were previously didn't have glib-networking
in systemd.packages so the PacRunner was non-functional.
@worldofpeace
nixos/pantheon: use glib-networking module
7802b18
@worldofpeace worldofpeace merged commit 27ac8cb into NixOS:master Apr 15, 2019
@worldofpeace worldofpeace deleted the glib-networking branch April 15, 2019 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @matthewbauer @jtojnar @GrahamcOfBorg