New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deadbeef 0.7.2 → 1.8.0 #59187
Deadbeef 0.7.2 → 1.8.0 #59187
Conversation
At the moment wildmidi plug-in is broken:
|
This also failed in the previous version, but it never showed a dialog box for this:
|
Replacing our wildmidi.so with wildmidi.so from upstream fixed it. So did the one built using the following command in unpackPhase
cd source
cd plugins/wildmidi
gcc -shared -Iinclude -DWILDMIDI_VERSION=\"0.2.2\" -DWILDMIDILIB_VERSION=\"0.2.2\" -DTIMIDITY_CFG=\"/etc/timidity.conf\" -fPIC wildmidiplug.c src/wildmidi_lib.c include/wildmidi_lib.h -o wildmidi.so -lm If we build deadbeef with debugging info using $ nm -A -D -l result/lib/deadbeef/wildmidi.so
result/lib/deadbeef/wildmidi.so:0000000000018080 B X /build/source/plugins/wildmidi/src/wildmidi_lib.c:399 Apparently, it is from this global variable: But its name is I tried |
- Add native opus support - Remove wildmidi dependency, deadbeef uses its own fork
opus support is now built into deadbeef
The EDIT: Ah, didn't notice you pushed a new version. Your patch is much cleaner than using dontPatchELF! |
Confirmed to be working with the patch. 👍 Thank you! |
I can reproduce it with |
Motivation for this change
http://deadbeef.sourceforge.net/posts/deadbeef_1.8.0_is_out.html
Added native opus support
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)