Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: c2e96734a33d
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: e0205c119ff9
Choose a head ref
  • 2 commits
  • 10 files changed
  • 2 contributors

Commits on Apr 7, 2019

  1. codimd: build with nodejs-8_x 

    This diff regenerates the package sets for `codimd` and `codemirror`
using NodeJS 8 to get rid of the deprecated[1] `nodejs-6_x`.

Additionally the following issues had to be fixed during the update:

* The package `js-sequence-diagram` has been removed from the NPM
  registry and was replaced by a security holding package[2]. The
  package was published by a third-party (upstream only supports bower
  builds), so it's unclear whether the package will re-appear[3].

  As the tarballs still exist (and the hash didn't change), the package
  will be loaded manually into the build env.

* For the babel-related packages, `dontNpmInstall` will be set for
  `node2nix` installs as some of those packages bundle a
  `package-lock.json` that triggers `ENOTCACHED` errors for optional
  dependencies[4].

For now it should be sufficient to use NodeJS 8 (`codimd` v1.2.x doesn't
support NodeJS 10), in the long term we probably want to use `yarn2nix`
here with NodeJS 10. This is much rather a fix to get rid of another
NodeJS 6 dependency.

[1] `nodejs-6_x` is about to be deprecated, see #58976
[2] https://www.npmjs.com/package/js-sequence-diagrams,
    https://github.com/npm/security-holder
[3] bramp/js-sequence-diagrams#212
[4] svanderburg/node2nix#134
    @Ma27
    Ma27 committed Apr 7, 2019
    Copy the full SHA
    5feec42 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #59118 from Ma27/codimd-node-8 

    codimd: build with nodejs-8_x
    @lheckemann
    lheckemann committed Apr 7, 2019
    Copy the full SHA
    e0205c1 View commit details
    Browse the repository at this point in the history