Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jackett: 0.10.846 -> 0.11.170 #59150

Merged
merged 1 commit into from Apr 9, 2019
Merged

jackett: 0.10.846 -> 0.11.170 #59150

merged 1 commit into from Apr 9, 2019

Conversation

Vskilet
Copy link
Contributor

@Vskilet Vskilet commented Apr 8, 2019 •
edited

Motivation for this change

Update of jackett and fix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Vskilet
Copy link
Contributor Author

Vskilet commented Apr 8, 2019

This is a review job for @edwtjo :-)

@etu
Copy link
Contributor

etu commented Apr 8, 2019

@GrahamcOfBorg build nixosTests.jackett jackett

@pSub
Copy link
Member

pSub commented Apr 9, 2019

@Vskilet Do you know if jackett is broken on 19.03? If so, this should probably be backported to 19.03 as well.

@pSub pSub merged commit efa0c65 into NixOS:master Apr 9, 2019
@Ma27
Copy link
Member

Ma27 commented Apr 9, 2019

It doesn't seem to fail, on release-19.03 (7f35ea8) a prebuilt jackett will be fetched from Hydra.

@Vskilet
Copy link
Contributor Author

Vskilet commented Apr 9, 2019

It doesn't failed but the ygg configuration change so I could backport it to 19.03

@Vskilet Vskilet deleted the jackett-update branch April 9, 2019 09:51
@Vskilet Vskilet restored the jackett-update branch April 9, 2019 09:52
@pSub
Copy link
Member

pSub commented Apr 9, 2019

If you cannot use it due to the configuration change than it makes sense to backport it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu etu approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Vskilet @etu @pSub @Ma27 @GrahamcOfBorg