Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dropbox-cli: replace python by python3 #59115

Merged
merged 1 commit into from Apr 7, 2019
Merged

dropbox-cli: replace python by python3 #59115

merged 1 commit into from Apr 7, 2019

Conversation

bricewge
Copy link
Contributor

@bricewge bricewge commented Apr 7, 2019 •
edited

fix #59110

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Apr 7, 2019

@GrahamcOfBorg build dropbox-cli

@xeji
Copy link
Contributor

xeji commented Apr 7, 2019

unfree package, build checked locally for x86_64-linux

@xeji xeji merged commit 5441285 into NixOS:master Apr 7, 2019
@mnacamura
Copy link
Contributor

mnacamura commented May 1, 2019 •
edited

After this update,

> nix-shell -p dropbox-cli --run 'dropbox start -i'
Starting Dropbox...Traceback (most recent call last):
  File "/nix/store/b4k8y53y9lk6avgqbpavm188vqmx1hxs-dropbox-cli-2019.02.14/bin/dropbox", line 1443, in start
    download()
  File "/nix/store/b4k8y53y9lk6avgqbpavm188vqmx1hxs-dropbox-cli-2019.02.14/bin/dropbox", line 294, in download
    import gi
ModuleNotFoundError: No module named 'gi'

@bricewge
Copy link
Contributor Author

bricewge commented May 1, 2019

When this commit is reverted the issue is still present. I think it came from version 2019.012.14 since other distro have the same issue https://aur.archlinux.org/packages/nautilus-dropbox/. You should open a new issue.

@mnacamura mnacamura mentioned this pull request May 2, 2019
Closed
@mnacamura
Copy link
Contributor

@bricewge Thanks for the information. I opened a new issue #60714.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-kenny the-kenny Awaiting requested review from the-kenny

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dropbox-cli: shebang is not modified by patchShebangs
4 participants
@bricewge @xeji @mnacamura @GrahamcOfBorg