Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes: 1.13.5 -> 1.14.0 #59119

Merged
merged 1 commit into from Apr 9, 2019
Merged

kubernetes: 1.13.5 -> 1.14.0 #59119

merged 1 commit into from Apr 9, 2019

Conversation

arianvp
Copy link
Member

@arianvp arianvp commented Apr 7, 2019 •
edited

Motivation for this change

A new release was done.

I opened against staging because this requires 1.12.1 of golang

I have not yet ran the nixos tests, as I am still rebuilding kubernetes
There might be some stuff that fails,

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@arianvp
Copy link
Member Author

arianvp commented Apr 7, 2019

building the docs failed with the following cryptic error message:

!!! Error in ./hack/update-generated-docs.sh:36
  Error in ./hack/update-generated-docs.sh:36. 'make -C "${KUBE_ROOT}" WHAT="${BINS[*]}"' exited with status 2
Call stack:
  1: ./hack/update-generated-docs.sh:36 main(...)
Exiting with status 1

@arianvp
Copy link
Member Author

arianvp commented Apr 7, 2019

Fixed the build.

@arianvp
Copy link
Member Author

arianvp commented Apr 7, 2019

I have not yet been able to run the NixOS tests, because many of the dependencies it depends on are in staging and don't have a cached version yet. I don't have the compute power to compute gnupg and openldap from scratch.

@arianvp
Copy link
Member Author

arianvp commented Apr 7, 2019

@GrahamcOfBorg test kubernetes.dns kubernetes.rbac

1 similar comment
@flokli
Copy link
Contributor

flokli commented Apr 7, 2019

@GrahamcOfBorg test kubernetes.dns kubernetes.rbac

@arianvp arianvp changed the title kubernetes: 1.35.5 -> 1.14.0 kubernetes: 1.13.5 -> 1.14.0 Apr 7, 2019
@arianvp
Copy link
Member Author

arianvp commented Apr 7, 2019

I'm not sure why the aarch64 build failed. But we are also skipping tests in aarch64 . Note sure if that's on purpose

@FRidh
Copy link
Member

FRidh commented Apr 8, 2019

I have not yet been able to run the NixOS tests

That's fine, we can see the results as soon as this is in staging-next.

@arianvp
Copy link
Member Author

arianvp commented Apr 9, 2019

@GrahamcOfBorg build kubernetes

@arianvp
Copy link
Member Author

arianvp commented Apr 9, 2019

The build suceeds now on aarch64 as well and all tests pass. I think this is ready for merge.

@flokli flokli merged commit 94ecefe into NixOS:staging Apr 9, 2019
@flokli
Copy link
Contributor

flokli commented Apr 9, 2019

Thanks!

@arianvp arianvp deleted the update-k8s branch April 9, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arianvp @flokli @FRidh @GrahamcOfBorg