Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nginx: fix error in writeNginxConfig #59181

Merged
merged 1 commit into from Apr 10, 2019
Merged

nixos/nginx: fix error in writeNginxConfig #59181

merged 1 commit into from Apr 10, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Apr 8, 2019 •
edited

Motivation for this change

Fix this error #57979 (comment) - errounous semicolon after single-line location block
Added in test nginx string to check parsing configuration.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 8, 2019

cc @Mic92

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 8, 2019

@GrahamcOfBorg test nginx

@Mic92 Mic92 mentioned this pull request Apr 8, 2019
Closed
@Mic92 Mic92 merged commit 4d4f110 into NixOS:master Apr 10, 2019
@Mic92
Copy link
Member

Mic92 commented Apr 10, 2019

Thanks for the fix!

@Izorkin Izorkin deleted the nginx-format branch April 10, 2019 18:25
@4z3 4z3 mentioned this pull request Apr 5, 2021
Closed
10 tasks
Mic92
Mic92 reviewed Apr 20, 2021
View reviewed changes
pkgs/build-support/writers/default.nix
@@ -178,13 +178,20 @@ rec {
writeJSBin = name:
writeJS "/bin/${name}";

awkFormatNginx = builtins.toFile "awkFormat-nginx.awk" ''
Copy link
Member

@Mic92 Mic92 Apr 20, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this now given we have? slomkowski/nginx-config-formatter#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Izorkin @Mic92 @GrahamcOfBorg