zig: 0.3.0 -> 0.4.0 #59198
Merged
zig: 0.3.0 -> 0.4.0 #59198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump to use LLVM8, but just guessing ;).
andrewrk
approved these changes
Apr 9, 2019
| }; | ||
|
|
||
| nativeBuildInputs = [ cmake ]; | ||
| buildInputs = [ llvmPackages.clang-unwrapped llvmPackages.llvm libxml2 zlib ]; | ||
|
|
||
| cmakeFlags = [ | ||
| "-DCMAKE_BUILD_TYPE=Release" |
|
On Mon, 08 Apr 2019 23:39:12 -0700, Andrew Kelley ***@***.***> wrote:
andrewrk approved this pull request.
The default cmake build is Debug, which is fine considering this is the stage1 C++ compiler which really doesn't need to be Release. But Release would be fine too. I think it's fine either way.
> };
nativeBuildInputs = [ cmake ];
buildInputs = [ llvmPackages.clang-unwrapped llvmPackages.llvm libxml2 zlib ];
- cmakeFlags = [
- "-DCMAKE_BUILD_TYPE=Release"
The cmake setup-hook doodad actually sets this by default these days,
and just double-checked the `nix log` to confirm I see it there too :).
So this was meant as a small cleanup not a functional change :).
…
No more release?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#59198 (review) part: text/html
|
pSub
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump to use LLVM8, but just guessing ;).
Update: of course it does, here's
the release notes:
https://ziglang.org/download/0.4.0/release-notes.html
Built (updated) tetris example, LGTM!
(rem to grab its deps via nix-shell or so)
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)cc @andrewrk