Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/sshd: Remove obsolete Protocol options #59136

Merged
merged 1 commit into from Apr 8, 2019

Conversation

aneeshusa
Copy link
Contributor

Motivation for this change

OpenSSH removed server side support for the v.1 Protocol
in version 7.4: https://www.openssh.com/txt/release-7.4,
making this option a no-op.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

OpenSSH removed server side support for the v.1 Protocol
in version 7.4: https://www.openssh.com/txt/release-7.4,
making this option a no-op.
@xeji
Copy link
Contributor

xeji commented Apr 7, 2019

@GrahamcOfBorg test openssh

@aanderse
Copy link
Member

aanderse commented Apr 7, 2019

Question somewhat related to this PR: does someone take responsibility for keeping up to date with the latest security standards for this module? What is considered best practice for kexAlgorithms, etc... is an ever moving target. From the git history it looks like this module is updated whenever someone notices an issue, as opposed to someone keeping on top of it.

I'll also mention the Qualys scanner we utilize at work scanned a bunch of the NixOS 18.09 severs and had no issues with ssh configuration, so currently we are up to date with industry recommendations... but I'd like to make sure we stay that way.

@xeji
Copy link
Contributor

xeji commented Apr 8, 2019

There's the NixOS security team: https://nixos.org/nixos/security.html . As for how they work, best ask them 😄

@xeji
Copy link
Contributor

xeji commented Apr 8, 2019

Also, you can volunteer to be a maintainer of this module if you're interested.

@xeji xeji merged commit 24ae4ae into NixOS:master Apr 8, 2019
@aneeshusa aneeshusa deleted the remove-obsolete-sshd-protocol-options branch January 7, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants