Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bookworm: unstabled-2018-11-19 -> 1.1.1 #59139

Closed
wants to merge 1 commit into from

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Apr 7, 2019

This bumps bookworm to the latest release, now using meson as build
system.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This bumps bookworm to the latest release, now using meson as build
system.
};

nativeBuildInputs = [
bash
gobject-introspection
libxml2
meson
cmake
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now using meson?

@flokli
Copy link
Contributor Author

flokli commented Apr 7, 2019 via email

@worldofpeace
Copy link
Contributor

This on an unstable revision because we needed babluboy/bookworm@07fbf07 and I wanted the meson build

See:

Why downgrade?

@flokli
Copy link
Contributor Author

flokli commented Apr 8, 2019

Argh, I got confused with versioning, assumed this was an upgrade. Sorry for the noise.

@flokli flokli closed this Apr 8, 2019
@worldofpeace
Copy link
Contributor

TBH the versions confused me too 😄

Screenshot from 2019-04-08 03 17 10

The conflicting information, not to mention the dates.

@flokli flokli deleted the bookworm-1.1.1 branch April 8, 2019 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants