Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trivial-builders: Fix outdated comment on writeTextFile #59138

Merged
merged 1 commit into from Apr 8, 2019
Merged

trivial-builders: Fix outdated comment on writeTextFile #59138

merged 1 commit into from Apr 8, 2019

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Apr 7, 2019

Motivation for this change

Fix wrong comment.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

aneeshusa
aneeshusa approved these changes Apr 7, 2019
View reviewed changes
Copy link
Contributor

@aneeshusa aneeshusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me modulo one typo.

pkgs/build-support/trivial-builders.nix Outdated Show resolved Hide resolved
@nh2 nh2 force-pushed the writeTextFile-fix-comment branch from 3a0a488 to c4c2aa6 Compare April 7, 2019 23:13
@matthewbauer matthewbauer merged commit 33a259a into master Apr 8, 2019
@grahamc grahamc deleted the writeTextFile-fix-comment branch July 30, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aneeshusa aneeshusa aneeshusa approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nh2 @aneeshusa @matthewbauer @GrahamcOfBorg