Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-xbuild: init at 0.5.7 #59228

Merged
merged 1 commit into from Apr 10, 2019
Merged

cargo-xbuild: init at 0.5.7 #59228

merged 1 commit into from Apr 10, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Apr 9, 2019 •
edited

Motivation for this change

A tool helps people to automatically cross-compile the sysroot crates core, compiler_builtins, and alloc.

https://crates.io/crates/cargo-xbuild
https://github.com/rust-osdev/cargo-xbuild

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Apr 10, 2019

@GrahamcOfBorg build cargo-xbuild

@xeji xeji merged commit 5770570 into NixOS:master Apr 10, 2019
@xrelkd xrelkd deleted the cargo-xbuild branch April 10, 2019 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xrelkd @xeji @matthiasbeyer @GrahamcOfBorg